netdev - Re: Netlink handler for ethtool --show-rxfh breaks driver compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <sh7guaacuwvah2rm7xz4g2zeips6weu4bxmnxv677njcfmyrkh@eyx7g4ueovxz>
Date: Mon, 15 Jul 2024 17:45:07 +0200
From: Michal Kubecek <mkubecek@...e.cz>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Vladimir Oltean <vladimir.oltean@....com>, 
	"Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	Wei Fang <wei.fang@....com>, "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Subject: Re: Netlink handler for ethtool --show-rxfh breaks driver
 compatibility

On Mon, Jul 15, 2024 at 08:26:00AM -0700, Jakub Kicinski wrote:
> On Mon, 15 Jul 2024 18:05:43 +0300 Vladimir Oltean wrote:
> 
> > Semantical differences / lack thereof aside - it is factually not the
> > same thing to report a number retrieved through a different UAPI
> > interface in the netlink handler variant for the same command.
> > You have the chance of either reporting a different number on the same
> > NIC
> 
> They can provide a different number? Which number is the user
> supposed to trust? Out of the 4 APIs we have? Or the NIC has
> a different ring count depending on the API?

This is IMHO the most important question. My understanding was that
those two APIs provide just two different ways to query the same value
and the existence of both is rather result of evolution than intent.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)