netdev - Re: [PATCH net-next 4/9] bnxt_en: Deprecate support for legacy INTX mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLin5PCsaiWuv2JE2NHDT=kB8oSHmSzCWNuccvAfs4f0dqw@mail.gmail.com>
Date: Mon, 15 Jul 2024 09:24:01 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Simon Horman <horms@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, pavan.chebbi@...adcom.com, 
	andrew.gospodarek@...adcom.com, Hongguang Gao <hongguang.gao@...adcom.com>, 
	Kalesh AP <kalesh-anakkur.purayil@...adcom.com>, 
	Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net-next 4/9] bnxt_en: Deprecate support for legacy INTX mode

On Mon, Jul 15, 2024 at 2:28 AM Simon Horman <horms@...nel.org> wrote:
>
> On Sat, Jul 13, 2024 at 04:43:34PM -0700, Michael Chan wrote:
> The minor problem flagged below not withstanding,
>
> Reviewed-by: Simon Horman <horms@...nel.org>
>
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
>
> ...
>
> > @@ -15743,8 +15714,10 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> >       if (BNXT_PF(bp))
> >               SET_NETDEV_DEVLINK_PORT(dev, &bp->dl_port);
> >
> > -     if (pdev->msix_cap)
> > -             bp->flags |= BNXT_FLAG_MSIX_CAP;
> > +     if (!pdev->msix_cap) {
> > +             dev_err(&pdev->dev, "MSIX capability not found, aborting\n");
> > +             return -ENODEV;
> > +     }
>
> Given where we are in the release cycle, perhaps this can be addressed
> as a follow-up. But it appears that the above leaks dev.
>
> Flagged by Smatch

Simon, thanks for the review.  You are absolutely right about leaking
dev.  I will not send out v2 since net-next is already closed.  Yes, I
will follow up with a fix if the patchset is applied.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)