netdev - Re: [PATCH net-next 5/9] bnxt_en: Remove BNXT_FLAG_USING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLinO3TSuZPppTWSU+P6ORfFQdWZLqyO5v48uxKbT8aS+hQ@mail.gmail.com>
Date: Mon, 15 Jul 2024 11:00:27 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, pavan.chebbi@...adcom.com, 
	andrew.gospodarek@...adcom.com, 
	Kalesh AP <kalesh-anakkur.purayil@...adcom.com>, 
	Somnath Kotur <somnath.kotur@...adcom.com>, Hongguang Gao <hongguang.gao@...adcom.com>
Subject: Re: [PATCH net-next 5/9] bnxt_en: Remove BNXT_FLAG_USING_MSIX flag

On Mon, Jul 15, 2024 at 10:32 AM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Sat, Jul 13, 2024 at 04:43:35PM -0700, Michael Chan wrote:
> > Now that we only support MSIX, the BNXT_FLAG_USING_MSIX is always true.
> > Remove it and any if conditions checking for it.  Remove the INTX
> > handler and associated logic.
>
> The cover letter says new firmware (the revision isn't mentioned)
> doesn't support INTx.  I guess it's OK if the new driver without INTx
> support runs on adapters with old firmware that still supports INTx?
> So the INTx support was never a real benefit?  I assume this driver
> change won't force a simultaneous firmware update?  The old driver
> might work in a "pci=nomsi" situation, but the new one probably won't?
> Just checking to be sure these are all acceptable consequences.

INTx was used as a fall-back mechanism in case MSIX wasn't available.

A new driver running on a NIC with older FW will work fine in MSIX
mode.  MSIX is always supported on any version of FW.  A new driver
obviously will not work in INTx mode even if the FW supports it.  But
INTx hasn't been tested for so many years that I won't be surprised if
it doesn't work using all older components that should support it.
Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)