netdev - Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3fa592d-91d7-45f0-9ca2-824feb610df8@wanadoo.fr>
Date: Mon, 15 Jul 2024 22:24:39 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Jakub Kicinski <kuba@...nel.org>
Cc: xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Paul Durrant <paul@....org>, Wei Liu <wei.liu@...nel.org>,
 LKML <linux-kernel@...r.kernel.org>, Markus Elfring <Markus.Elfring@....de>
Subject: Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()

Le 15/07/2024 à 18:01, Jakub Kicinski a écrit :
> On Sat, 13 Jul 2024 15:18:42 +0200 Markus Elfring wrote:
>> Single characters (line breaks) should be put into a sequence.
>> Thus use the corresponding function “seq_putc”.
>>
>> This issue was transformed by using the Coccinelle software.
> 
> I prefer to only merge trivial changes like this if maintainer
> indicates their support by acking them. Since the merge window
> has opened we can't wait and see so I'm marking this patch and
> your pktgen patch as deferred.
> 
> 

Hi Jakub,

Most of the time, this kind of modification is useless because it is 
already done by the compiler, see [1].

CJ

[1]: 
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/seq_file.h#L123