netdev - Re: [PATCH net-next v3 2/2] vsock/virtio: avoid queuing packets when work queue is empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <VI1P194MB2166D217DAB34D4A774FA2129AA12@VI1P194MB2166.EURP194.PROD.OUTLOOK.COM>
Date: Mon, 15 Jul 2024 12:44:49 +0200
From: Luigi Leonardi <luigi.leonardi@...look.com>
To: sgarzare@...hat.com
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	luigi.leonardi@...look.com,
	marco.pinn95@...il.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	stefanha@...hat.com,
	virtualization@...ts.linux.dev
Subject: Re: [PATCH net-next v3 2/2] vsock/virtio: avoid queuing packets when work queue is empty

Hi Stefano,

Thanks for your review!

> On Thu, Jul 11, 2024 at 04:58:47PM GMT, Luigi Leonardi via B4 Relay wrote:
> >From: Luigi Leonardi <luigi.leonardi@...look.com>
> >
> >Introduce an optimization in virtio_transport_send_pkt:
> >when the work queue (send_pkt_queue) is empty the packet is
>
> Note: send_pkt_queue is just a queue of sk_buff, is not really a work
> queue.
>
> >put directly in the virtqueue increasing the throughput.
>
> Why?
My guess is that is due to the hotpath being faster, there is (potentially) one less
step!
>
> I tested the patch and everything seems to be fine, all my comments are
> minor and style, the code should be fine!
Great, I'll send a v4 addressing all your comments :)

Thanks,
Luigi