netdev - Re: Netlink handler for ethtool --show-rxfh breaks driver compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240715061137.3df01bf2@kernel.org>
Date: Mon, 15 Jul 2024 06:11:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Vladimir Oltean <vladimir.oltean@....com>, "Mogilappagari, Sudheer"
 <sudheer.mogilappagari@...el.com>
Cc: Michal Kubecek <mkubecek@...e.cz>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, Wei Fang <wei.fang@....com>, "Samudrala, Sridhar"
 <sridhar.samudrala@...el.com>
Subject: Re: Netlink handler for ethtool --show-rxfh breaks driver
 compatibility

On Mon, 15 Jul 2024 14:58:07 +0300 Vladimir Oltean wrote:
> Looking at Documentation/networking/ethtool-netlink.rst, I see
> ETHTOOL_GRXRINGS has no netlink equivalent. So print_indir_table()
> should still be called with the result of the ETHTOOL_GRXRINGS ioctl
> even in the netlink case?

How about we fall back to the old method if netlink returns EOPNOTSUPP
for CHANNELS_GET? The other API is a bit of a historic coincidence.