netdev - RE: [LINUX PATCH] net: axienet: Fix axiethernet register description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB59535D1EFDEB3C2668CA2109B7A22@MN0PR12MB5953.namprd12.prod.outlook.com>
Date: Tue, 16 Jul 2024 19:40:57 +0000
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To: Andrew Lunn <andrew@...n.ch>, "Gupta, Suraj" <Suraj.Gupta2@....com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "Simek, Michal"
	<michal.simek@....com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>, "Katakam,
 Harini" <harini.katakam@....com>
Subject: RE: [LINUX PATCH] net: axienet: Fix axiethernet register description

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Saturday, July 13, 2024 8:25 PM
> To: Gupta, Suraj <Suraj.Gupta2@....com>
> Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; Simek, Michal <michal.simek@....com>;
> netdev@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; git (AMD-Xilinx) <git@....com>; Katakam, Harini
> <harini.katakam@....com>
> Subject: Re: [LINUX PATCH] net: axienet: Fix axiethernet register description
> 
> On Sat, Jul 13, 2024 at 06:48:07PM +0530, Suraj Gupta wrote:
> > Rename axiethernet register description to be inline with product guide
> > register names. It also removes obsolete registers and bitmasks. There is
> > no functional impact since the modified offsets are only renamed.
> >
> > Rename XAE_PHYC_OFFSET->XAE_RMFC_OFFSET (Only used in ethtool
> get_regs)
> > XAE_MDIO_* : update documentation comment.
> > Remove unused Bit masks for Axi Ethernet PHYC register.
> > Remove bit masks for MDIO interface MIS, MIP, MIE, MIC registers.
> > Rename XAE_FMI -> XAE_FMC.
> 
> Might be too way out there, but why not modify the documentation to
> fit Linux? This driver is likely to get bug fixes, and renames like

The problem is documentation is common for other software stacks as well
like baremetal/RTOS.

Considering this i feel better to correct the names and align with IP register 
description else someone reading code may think this reg is related to 
some other configurations.

Example: XAE_PHYC_OFFSET is corrected/renamed to XAE_RMFC_OFFSET.
RX Max Frame Configuration 0x00000414 R/W
XAE_RMFC_OFFSET is only used in ethtool get_regs. 

Other changes are removing unused bits masks (Remove unused Bit masks for 
Axi Ethernet PHYC register,  Remove bit masks for MDIO interface MIS, MIP, 
MIE, MIC registers) so should be fine to remove the dead code.

Thanks.
> this make it harder to backport those fixes. Documentation on the
> other hand just tends to get erratas, either in a separate document,
> or appended to the beginning/end. There is no applying patches to
> documentation.
> 
> 	Andrew