netdev - Re: [PATCH v2 2/4] can: flexcan: Add S32V234 support to FlexCAN driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240716-magnificent-imported-ammonite-06274a-mkl@pengutronix.de>
Date: Tue, 16 Jul 2024 08:56:34 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Frank Li <Frank.Li@....com>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org, 
	netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	haibo.chen@....com, imx@...ts.linux.dev, han.xu@....com, 
	Chircu-Mare Bogdan-Petru <Bogdan.Chircu@...escale.com>, Dan Nica <dan.nica@....com>, 
	Stefan-Gabriel Mirea <stefan-gabriel.mirea@....com>, Li Yang <leoyang.li@....com>, 
	Joakim Zhang <qiangqing.zhang@....com>, Leonard Crestez <cdleonard@...il.com>
Subject: Re: [PATCH v2 2/4] can: flexcan: Add S32V234 support to FlexCAN
 driver

On 15.07.2024 17:27:21, Frank Li wrote:
> From: Chircu-Mare Bogdan-Petru <Bogdan.Chircu@...escale.com>
> 
> Add flexcan support for S32V234.
> 
> Signed-off-by: Chircu-Mare Bogdan-Petru <Bogdan.Chircu@...escale.com>
> Signed-off-by: Dan Nica <dan.nica@....com>
> Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@....com>
> Reviewed-by: Li Yang <leoyang.li@....com>
> Reviewed-by: Joakim Zhang <qiangqing.zhang@....com>
> Reviewed-by: Leonard Crestez <leonard.crestez@....com>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  drivers/net/can/flexcan/flexcan-core.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
> index 8ea7f2795551b..f6e609c388d55 100644
> --- a/drivers/net/can/flexcan/flexcan-core.c
> +++ b/drivers/net/can/flexcan/flexcan-core.c
> @@ -378,6 +378,10 @@ static const struct flexcan_devtype_data fsl_lx2160a_r1_devtype_data = {
>  		FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX_RTR,
>  };
>  
> +static struct flexcan_devtype_data fsl_s32v234_devtype_data = {
> +	.quirks = FLEXCAN_QUIRK_DISABLE_RXFG | FLEXCAN_QUIRK_DISABLE_MECR,
> +};

- Does the core support CAN-FD?
- Does the core generate an error interrupt when going from error warning
  to error passive?
- Are you sure, you don't need to enable FLEXCAN_QUIRK_ENABLE_EACEN_RRS?
- You probably want to use the mailboxes instead of the FIFO for the
  RX-path.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)