netdev - [PATCH 4/4] net: dsa: microchip: ksz9477: correct description of WoL functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240717193725.469192-5-vtpieter@gmail.com>
Date: Wed, 17 Jul 2024 21:37:25 +0200
From: vtpieter@...il.com
To: devicetree@...r.kernel.org,
	woojung.huh@...rochip.com,
	UNGLinuxDriver@...rochip.com,
	netdev@...r.kernel.org
Cc: o.rempel@...gutronix.de,
	Pieter Van Trappen <pieter.van.trappen@...n.ch>
Subject: [PATCH 4/4] net: dsa: microchip: ksz9477: correct description of WoL functions

From: Pieter Van Trappen <pieter.van.trappen@...n.ch>

Correct KSZ9477 WoL function description, found when evaluating it for
usage at KSZ8795 family of switches.

Signed-off-by: Pieter Van Trappen <pieter.van.trappen@...n.ch>
---
 drivers/net/dsa/microchip/ksz9477.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c
index 425e20daf1e9..1344b60ee2c3 100644
--- a/drivers/net/dsa/microchip/ksz9477.c
+++ b/drivers/net/dsa/microchip/ksz9477.c
@@ -95,9 +95,9 @@ static int ksz9477_handle_wake_reason(struct ksz_device *dev, int port)
  * @port: The port number.
  * @wol: Pointer to ethtool Wake-on-LAN settings structure.
  *
- * This function checks the PME Pin Control Register to see if  PME Pin Output
- * Enable is set, indicating PME is enabled. If enabled, it sets the supported
- * and active WoL flags.
+ * This function checks the PME 'wakeup-source' property from the
+ * device tree. If enabled, it sets the supported and active WoL
+ * flags.
  */
 void ksz9477_get_wol(struct ksz_device *dev, int port,
 		     struct ethtool_wolinfo *wol)
@@ -135,7 +135,7 @@ void ksz9477_get_wol(struct ksz_device *dev, int port,
  *
  * This function configures Wake-on-LAN (WoL) settings for a specified port.
  * It validates the provided WoL options, checks if PME is enabled via the
- * switch's PME Pin Control Register, clears any previous wake reasons,
+ * switch's device tree property, clears any previous wake reasons,
  * and sets the Magic Packet flag in the port's PME control register if
  * specified.
  *
-- 
2.43.0