netdev - Re: [PATCH net-next] net: drop special comment style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <678590f7-a550-42b7-b8a0-a40eb3313030@linux.ibm.com>
Date: Wed, 17 Jul 2024 11:22:00 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Johannes Berg <johannes@...solutions.net>, netdev@...r.kernel.org
Cc: Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH net-next] net: drop special comment style



On 16.07.24 22:48, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> As we just discussed (in the room at netdevconf), drop the
> requirement for special comment style for netdev.
> 
> For checkpatch, the general check accepts both right now,
> so simply drop the special request there as well.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
>  Documentation/process/maintainer-netdev.rst | 17 -----------------
>  scripts/checkpatch.pl                       | 10 ----------
>  2 files changed, 27 deletions(-)
> 
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index 5e1fcfad1c4c..5a411c52b466 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst


I guess you should also remove the section in 

diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
index 7e768c65aa92..3ccda9f42cfa 100644
--- a/Documentation/process/coding-style.rst
+++ b/Documentation/process/coding-style.rst
@@ -629,18 +629,6 @@ The preferred style for long (multi-line) comments is:
         * with beginning and ending almost-blank lines.
         */

-For files in net/ and drivers/net/ the preferred style for long (multi-line)
-comments is a little different.
-
-.. code-block:: c
-
-       /* The preferred comment style for files in net/ and drivers/net
-        * looks like this.
-        *
-        * It is nearly the same as the generally preferred comment style,
-        * but there is no initial almost-blank line.
-        */
-
 It's also important to comment data, whether they are basic types or derived
 types.  To this end, use just one data declaration per line (no commas for
 multiple data declarations).  This leaves you room for a small comment on each