netdev - Re: [Intel-wired-lan] [PATCH iwl-next v3 10/13] ice: add method to disable FDIR SWAP option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b86c8136-56cc-4a88-9ca4-3c0d7e849bd0@molgen.mpg.de>
Date: Wed, 17 Jul 2024 11:55:13 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Ahmed Zaki <ahmed.zaki@...el.com>
Cc: Junfeng Guo <junfeng.guo@...el.com>, netdev@...r.kernel.org,
 anthony.l.nguyen@...el.com, Marcin Szycik <marcin.szycik@...ux.intel.com>,
 intel-wired-lan@...ts.osuosl.org, horms@...nel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 10/13] ice: add method to
 disable FDIR SWAP option

Dear Ahmed,


Thank you for your reply.


Am 15.07.24 um 16:23 schrieb Ahmed Zaki:

> On 2024-07-10 10:59 p.m., Paul Menzel wrote:

>> Am 10.07.24 um 22:40 schrieb Ahmed Zaki:
>>> From: Junfeng Guo <junfeng.guo@...el.com>
>>>
>>> The SWAP Flag in the FDIR Programming Descriptor doesn't work properly,
>>> it is always set and cannot be unset (hardware bug).
>>
>> Please document the datasheet/errata.
> 
> Unfortunately, I don't think this is in any docs or errata.

Oh. How did you find out?

>>> Thus, add a method to effectively disable the FDIR SWAP option by
>>> setting the FDSWAP instead of FDINSET registers.
>>
>> Please paste the new debug messages.
> 
> What debug messages? If you mean the ones logged by ice_debug() in this 
> patch, please note fvw_num = 48 for the parser. So that's 96 lines of:
> 
> swap wr(%d, %d): 0x%x = 0x%08x
> inset wr(%d, %d): 0x%x = 0x%08x

Personally, I’d prefer an example line, but I know that it’s not common.

[…]


Kind regards,

Paul