netdev - Re: [PATCH net] eth: fbnic: don't build the driver when skb has more than 25 frags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240717071218.72ec1bc6@kernel.org>
Date: Wed, 17 Jul 2024 07:12:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 alexanderduyck@...com, kernel-team@...a.com
Subject: Re: [PATCH net] eth: fbnic: don't build the driver when skb has
 more than 25 frags

On Wed, 17 Jul 2024 15:44:09 +0200 Paolo Abeni wrote:
> I think that with aarch MAX_SKB_FRAGS should be max 21. Aarch cacheline 
> size is 128, right? The frag independent part of skb_shared_info takes 
> 48 bytes, and sizeof(skb_frag_t) == 16:
> 
> (512 - 128 - 48)/16 = 21

Hm, my grep foo must be low, I don't see aarch64 with 128B cache lines.
But I do see powerpc, so we can stick to 21 to be safe.