netdev - Re: [PATCH net v2] eth: fbnic: don't build the driver when skb has more than 21 frags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5021a2aa-1398-4b3d-b1fc-6bbb2d85dfbb@redhat.com>
Date: Thu, 18 Jul 2024 15:25:18 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, alexanderduyck@...com,
 kernel-team@...a.com
Subject: Re: [PATCH net v2] eth: fbnic: don't build the driver when skb has
 more than 21 frags



On 7/17/24 18:15, Jakub Kicinski wrote:
> Similarly to commit 0e03c643dc93 ("eth: fbnic: fix s390 build."),
> the driver won't build if skb_shared_info has more than 25 frags
> assuming a 64B cache line and 21 frags assuming a 128B cache line.
> 
>    (512 - 48 -  64) / 16 = 25
>    (512 - 48 - 128) / 16 = 21
> 
> Fixes: 0cb4c0a13723 ("eth: fbnic: Implement Rx queue alloc/start/stop/free")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Paolo Abeni <pabeni@...hat.com>