netdev - Re: [RFC PATCH 1/2] netpoll: extract core of netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff42f723b718c7ac8aee992ba0719cb56910ebe3.camel@surriel.com>
Date: Thu, 18 Jul 2024 15:47:43 -0400
From: Rik van Riel <riel@...riel.com>
To: Breno Leitao <leitao@...ian.org>, kuba@...nel.org, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com
Cc: thepacketgeek@...il.com, horms@...nel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, paulmck@...nel.org, davej@...emonkey.org.uk
Subject: Re: [RFC PATCH 1/2] netpoll: extract core of netpoll_cleanup

On Thu, 2024-07-18 at 11:43 -0700, Breno Leitao wrote:
> Extract the core part of netpoll_cleanup(), so, it could be called
> from
> a caller that has the rtnl lock already.
> 
> Netconsole uses this in a weird way right now:
> 
> 	__netpoll_cleanup(&nt->np);
> 	spin_lock_irqsave(&target_list_lock, flags);
> 	netdev_put(nt->np.dev, &nt->np.dev_tracker);
> 	nt->np.dev = NULL;
> 	nt->enabled = false;
> 
> This will be replaced by do_netpoll_cleanup() as the locking
> situation
> is overhauled.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Rik van Riel <riel@...riel.com>

-- 
All Rights Reversed.