netdev - Re: [PATCH bpf 0/3] xsk: require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <284c6aba-8872-f971-7adb-60ed5ab3c29c@iogearbox.net>
Date: Fri, 19 Jul 2024 17:22:35 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Stanislav Fomichev <sdf@...ichev.me>, bpf@...r.kernel.org,
 netdev@...r.kernel.org
Cc: ast@...nel.org, andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org,
 yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com,
 haoluo@...gle.com, jolsa@...nel.org, Julian Schindel
 <mail@...tic-alpaca.de>, Magnus Karlsson <magnus.karlsson@...il.com>,
 maciej.fijalkowski@...el.com
Subject: Re: [PATCH bpf 0/3] xsk: require XDP_UMEM_TX_METADATA_LEN to actuate
 tx_metadata_len

On 7/13/24 3:52 AM, Stanislav Fomichev wrote:
> Julian reports that commit 341ac980eab9 ("xsk: Support tx_metadata_len")
> can break existing use cases which don't zero-initialize xdp_umem_reg
> padding. Fix it (while still breaking a minority of new users of tx
> metadata), update the docs, update the selftest and sprinkle some
> BUILD_BUG_ONs to hopefully catch similar issues in the future.
> 
> Thank you Julian for the report and for helping to chase it down!
> 
> Reported-by: Julian Schindel <mail@...tic-alpaca.de>
> Cc: Magnus Karlsson <magnus.karlsson@...il.com>
> 
> Stanislav Fomichev (3):
>    xsk: require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len
>    selftests/bpf: Add XDP_UMEM_TX_METADATA_LEN to XSK TX metadata test
>    xsk: Try to make xdp_umem_reg extension a bit more future-proof
> 
>   Documentation/networking/xsk-tx-metadata.rst  | 16 ++++++++-----
>   include/uapi/linux/if_xdp.h                   |  4 ++++
>   net/xdp/xdp_umem.c                            |  9 +++++---
>   net/xdp/xsk.c                                 | 23 ++++++++++---------
>   tools/include/uapi/linux/if_xdp.h             |  4 ++++
>   .../selftests/bpf/prog_tests/xdp_metadata.c   |  3 ++-
>   6 files changed, 38 insertions(+), 21 deletions(-)
> 

Magnus or Maciej, ptal when you get a chance.

Thanks,
Daniel