netdev - Re: [syzbot] [wireless?] INFO: task hung in rfkill_global_led_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9f8412dac004da0a192376a235ced2412299fb8.camel@sipsolutions.net>
Date: Fri, 19 Jul 2024 09:30:10 -0700
From: Johannes Berg <johannes@...solutions.net>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>, Krzysztof Kozlowski
	 <krzk@...nel.org>
Cc: syzbot+50499e163bfa302dfe7b@...kaller.appspotmail.com, syzkaller-bugs
 <syzkaller-bugs@...glegroups.com>, Network Development
 <netdev@...r.kernel.org>,  LKML <linux-kernel@...r.kernel.org>,
 linux-wireless <linux-wireless@...r.kernel.org>
Subject: Re: [syzbot] [wireless?] INFO: task hung in
 rfkill_global_led_trigger_worker (3)

On Fri, 2024-07-19 at 22:59 +0900, Tetsuo Handa wrote:
> This is a deadlock which lockdep cannot detect.
> Please check which lock should be taken first.
> 
> 2 locks held by syz.1.2508/23558:
>  #0: ffff88805ff4f100 (&dev->mutex){....}-{3:3}, at: device_lock include/linux/device.h:1009 [inline]
>  #0: ffff88805ff4f100 (&dev->mutex){....}-{3:3}, at: nfc_unregister_device+0x63/0x2a0 net/nfc/core.c:1165
>  #1: ffffffff8f8e1b88 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_unregister+0xd0/0x230 net/rfkill/core.c:1149
> 2 locks held by syz.4.2510/23544:
>  #0: ffffffff8f8e1b88 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0x1a9/0x790 net/rfkill/core.c:1297
>  #1: ffff88805ff4f100 (&dev->mutex){....}-{3:3}, at: device_lock include/linux/device.h:1009 [inline]
>  #1: ffff88805ff4f100 (&dev->mutex){....}-{3:3}, at: nfc_dev_down net/nfc/core.c:143 [inline]
>  #1: ffff88805ff4f100 (&dev->mutex){....}-{3:3}, at: nfc_rfkill_set_block+0x50/0x310 net/nfc/core.c:179

Yeah, this is a well-known issue; I believe this should be fixed in the
NFC (virtual) device.

johannes