netdev - Re: [PATCH net-next v14 00/14] stmmac: Add Loongson platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd842676-6258-4aa5-9ec7-c23dbe3232d2@loongson.cn>
Date: Fri, 19 Jul 2024 18:09:10 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, si.yanteng@...ux.dev
Subject: Re: [PATCH net-next v14 00/14] stmmac: Add Loongson platform support


在 2024/7/18 21:32, Serge Semin 写道:
> Hi Yanteng
>
> On Mon, Jul 15, 2024 at 07:35:04PM +0800, Yanteng Si wrote:
>> 在 2024/7/11 23:35, Serge Semin 写道:
>>> Hi Yanteng
>>>
>>> On Tue, Jul 09, 2024 at 05:34:07PM +0800, Yanteng Si wrote:
>>>> v14:
>>>>
>>>> Because Loongson GMAC can be also found with the 8-channels AV feature
>>>> enabled, we'll need to reconsider the patches logic and thus the
>>>> commit logs too. As Serge's comments and Russell's comments:
>>>> [PATCH net-next v14 01/15] net: stmmac: Move the atds flag to the stmmac_dma_cfg structure
>>>> [PATCH net-next v14 02/15] net: stmmac: Add multi-channel support
>>>> [PATCH net-next v14 03/15] net: stmmac: Export dwmac1000_dma_ops
>>>> [PATCH net-next v14 04/15] net: stmmac: dwmac-loongson: Drop duplicated hash-based filter size init
>>>> [PATCH net-next v14 05/15] net: stmmac: dwmac-loongson: Drop pci_enable/disable_msi calls
>>>> [PATCH net-next v14 06/15] net: stmmac: dwmac-loongson: Use PCI_DEVICE_DATA() macro for device identification
>>>> [PATCH net-next v14 07/15] net: stmmac: dwmac-loongson: Detach GMAC-specific platform data init
>>>> +-> Init the plat_stmmacenet_data::{tx_queues_to_use,rx_queues_to_use}
>>>>       in the loongson_gmac_data() method.
>>>> [PATCH net-next v14 08/15] net: stmmac: dwmac-loongson: Init ref and PTP clocks rate
>>>> [PATCH net-next v14 09/15] net: stmmac: dwmac-loongson: Add phy_interface for Loongson GMAC
>>>> [PATCH net-next v14 10/15] net: stmmac: dwmac-loongson: Introduce PCI device info data
>>>> +-> Make sure the setup() method is called after the pci_enable_device()
>>>>       invocation.
>>>> [PATCH net-next v14 11/15] net: stmmac: dwmac-loongson: Add DT-less GMAC PCI-device support
>>>> +-> Introduce the loongson_dwmac_dt_config() method here instead of
>>>>       doing that in a separate patch.
>>>> +-> Add loongson_dwmac_acpi_config() which would just get the IRQ from
>>>>       the pdev->irq field and make sure it is valid.
>>>> [PATCH net-next v14 12/15] net: stmmac: Fixed failure to set network speed to 1000.
>>>> +-> Drop the patch as Russell's comments, At the same time, he provided another
>>>>       better repair suggestion, and I decided to send it separately after the
>>>>       patch set was merged. See:
>>>>       <https://lore.kernel.org/netdev/ZoW1fNqV3PxEobFx@shell.armlinux.org.uk/>
>>>> [PATCH net-next v14 13/15] net: stmmac: dwmac-loongson: Add Loongson Multi-channels GMAC support
>>>> +-> This is former "net: stmmac: dwmac-loongson: Add Loongson GNET
>>>>       support" patch, but which adds the support of the Loongson GMAC with the
>>>>       8-channels AV-feature available.
>>>> +-> loongson_dwmac_intx_config() shall be dropped due to the
>>>>       loongson_dwmac_acpi_config() method added in the PATCH 11/15.
>>>> +-> Make sure loongson_data::loongson_id  is initialized before the
>>>>       stmmac_pci_info::setup()  is called.
>>>> +-> Move the rx_queues_to_use/tx_queues_to_use and coe_unsupported
>>>>       fields initialization to the loongson_gmac_data() method.
>>>> +-> As before, call the loongson_dwmac_msi_config() method if the multi-channels
>>>>       Loongson MAC has been detected.
>>>> +-> Move everything GNET-specific to the next patch.
>>>> [PATCH net-next v14 14/15] net: stmmac: dwmac-loongson: Add Loongson GNET support
>>>> +-> Everything Loonsgson GNET-specific is supposed to be added in the
>>>>       framework of this patch:
>>>>       + PCI_DEVICE_ID_LOONGSON_GNET macro
>>>>       + loongson_gnet_fix_speed() method
>>>>       + loongson_gnet_data() method
>>>>       + loongson_gnet_pci_info data
>>>>       + The GNET-specific part of the loongson_dwmac_setup() method.
>>>>       + ...
>>>> [PATCH net-next v14 15/15] net: stmmac: dwmac-loongson: Add loongson module author
>>>>
>>>> Other's:
>>>> Pick Serge's Reviewed-by tag.
>>> Thanks for submitting an update. I've briefly looked at it and spotted a
>>> few places left to improve. I'll send my comments on the next week.
>> Okay, thank you for spending a lot of time and effort reviewing our patch.
> In case if you are willing to resubmit the series anytime soon, please
> note that 6.11 merge window was opened two days ago. So the series
> either need to be submitted as RFC v15 or you need to hold on with
> posting the patch set for the next two weeks.
>
Thanks, I will send RFC v15.


Thanks,

Yanteng