netdev - Re: [PATCH 2/4] net: dsa: microchip: ksz8795: add Wake on LAN support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHvy4ArOx2MhMmrgeosPbr8NLE6Kf=wWuL23+g-+2=Uf9UaFtQ@mail.gmail.com>
Date: Sat, 20 Jul 2024 14:44:10 +0200
From: Pieter <vtpieter@...il.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: devicetree@...r.kernel.org, woojung.huh@...rochip.com, 
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org, 
	Pieter Van Trappen <pieter.van.trappen@...n.ch>
Subject: Re: [PATCH 2/4] net: dsa: microchip: ksz8795: add Wake on LAN support

Le ven. 19 juil. 2024 à 15:46, Oleksij Rempel
<o.rempel@...gutronix.de> a écrit :
>
> Hi Pieter,
>
> If I see it correctly, the only difference between KSZ9477 and KSZ8795
> code is the register access. Even bit offsets are identical. I do not
> think indirect register access is good justification for duplication
> this amount of code.

Hi Oleksij, thanks for the review! I guess you're right - I must have
gone too quickly for the easy way out. There's actually one additional
register access for KSZ8795 but it should be possible to get around
this as well. I'll work on it but it might take me a few weeks to get
this ready. Would be great if you still have a KSZ9477 family board
around to validate.

Cheers, Pieter