netdev - Re: [PATCH bpf v5] bpf: Fixed segment issue when downgrade gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-+Hx9Tg-Fj+7hutPJ7inL_GpgiY4WAXXdhN-tzj5Q1caQ@mail.gmail.com>
Date: Mon, 22 Jul 2024 09:29:21 -0700
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Fred Li <dracodingfly@...il.com>
Cc: andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org, 
	daniel@...earbox.net, herbert@...dor.apana.org.au, john.fastabend@...il.com, 
	kpsingh@...nel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, 
	pabeni@...hat.com, song@...nel.org, yonghong.song@...ux.dev
Subject: Re: [PATCH bpf v5] bpf: Fixed segment issue when downgrade gso_size

On Sun, Jul 21, 2024 at 8:08 PM Fred Li <dracodingfly@...il.com> wrote:
>
> Linearize skb when downgrad gso_size to prevent triggering
> the BUG_ON during segment skb as described in [1].
>
> v5 changes:
>  - add bpf subject prefix.
>  - adjust message to imperative mood.
>
> v4 changes:
>  - add fixed tag.
>
> v3 changes:
>  - linearize skb if having frag_list as Willem de Bruijn suggested [2].
>
> [1] https://lore.kernel.org/all/20240626065555.35460-2-dracodingfly@gmail.com/
> [2] https://lore.kernel.org/all/668d5cf1ec330_1c18c32947@willemb.c.googlers.com.notmuch/
>
> Fixes: 2be7e212d541 ("bpf: add bpf_skb_adjust_room helper")
> Signed-off-by: Fred Li <dracodingfly@...il.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

My comments were informational, for a next patch if any, really. v4
was fine. v5 is too.