netdev - Re: [PATCH V3 00/10] PCIe TPH and cache direct injection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zp5ziFP6JidCODF6@wunner.de>
Date: Mon, 22 Jul 2024 16:58:16 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Wei Huang <wei.huang2@....com>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, netdev@...r.kernel.org,
	Jonathan.Cameron@...wei.com, helgaas@...nel.org, corbet@....net,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, alex.williamson@...hat.com, gospo@...adcom.com,
	michael.chan@...adcom.com, ajit.khaparde@...adcom.com,
	somnath.kotur@...adcom.com, andrew.gospodarek@...adcom.com,
	manoj.panicker2@....com, Eric.VanTassell@....com,
	vadim.fedorenko@...ux.dev, horms@...nel.org, bagasdotme@...il.com,
	bhelgaas@...gle.com, Paul Luse <paul.e.luse@...el.com>,
	Jing Liu <jing2.liu@...el.com>
Subject: Re: [PATCH V3 00/10] PCIe TPH and cache direct injection support

On Mon, Jul 22, 2024 at 09:44:32AM -0500, Wei Huang wrote:
> On 7/20/24 03:08, Lukas Wunner wrote:
> > Paul Luse submitted a patch two years ago to save and restore
> > TPH registers, perhaps you can include it in your patch set?
> 
> Thanks for pointing them out. I skimmed through Paul's patch and it is
> straightforward to integrate.
> 
> Depending on Bjorn's preference, I can either integrate it into my
> patchset with full credits to Paul and Jing, or Paul want to resubmit a
> new version.

The former would likely be better as I'm not sure Paul has the time
to respin the patch.  My recollection is that TPH save/restore support
was dropped as a requirement for the Intel device this was originally
developed for, but it would be a shame to lose the time and effort
that already went into it and I think it might be useful for your
use case as well to support reset recovery.

> I read Bjorn's comments, lots of them have been addressed in my patchset
> (e.g. move under /pci/pcie, support _DSM and dev->tph).

Indeed, good job!

Thanks for taking a look!

Lukas