netdev - Re: [OFFLIST RFC 3/4] bpf: Support bpf_kptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <darbgv5izfcghfynr3efoo5w5slsa7kmwcsqpbrasa2u3u76bl@sm4zq2drkjai>
Date: Mon, 22 Jul 2024 17:18:09 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Amery Hung <ameryhung@...il.com>
Cc: andrii@...nel.org, bpf@...r.kernel.org, daniel@...earbox.net, 
	jhs@...atatu.com, jiri@...nulli.us, martin.lau@...nel.org, netdev@...r.kernel.org, 
	sdf@...gle.com, sinquersw@...il.com, toke@...hat.com, xiyou.wangcong@...il.com, 
	yangpeihao@...u.edu.cn, yepeilin.cs@...il.com, donald.hunter@...il.com
Subject: Re: [OFFLIST RFC 3/4] bpf: Support bpf_kptr_xchg into local kptr

On Fri, Jul 19, 2024 at 05:21:18PM +0000, Amery Hung wrote:
> From: Dave Marchevsky <davemarchevsky@...com>
> 
> Signed-off-by: Dave Marchevsky <davemarchevsky@...com>

Amery,
please add your SOB after Dave's when you're sending patches like this.

Remove OFFLIST in subject... and resend cc-ing bpf@...r.

Add proper commit log.

> -	if (meta->func_id == BPF_FUNC_kptr_xchg && type_is_alloc(type)) {
> +	if (meta->func_id == BPF_FUNC_kptr_xchg && type_is_alloc(type) && regno > 1) {

I don't understand the point of regno > 1. Pls explain/add comment.

Patches 1 and 2 make sense.