netdev - Re: [RFC net-next 01/10] skbuff: Rename csum_not_inet to csum_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zp_Y87B-0yp9Tl3w@google.com>
Date: Tue, 23 Jul 2024 16:23:15 +0000
From: Mina Almasry <almasrymina@...gle.com>
To: Tom Herbert <tom@...bertland.com>
Cc: davem@...emloft.net, kuba@...nel.org, jesse.brandeburg@...el.com,
	anthony.l.nguyen@...el.com, cai.huoqing@...ux.dev,
	netdev@...r.kernel.org, felipe@...anda.io
Subject: Re: [RFC net-next 01/10] skbuff: Rename csum_not_inet to
 csum_is_crc32

On Wed, Jul 03, 2024 at 03:48:41PM -0700, Tom Herbert wrote:
> csum_not_inet really refers to SCTP or FCOE CRC. Rename
> to be more precise
>
> Signed-off-by: Tom Herbert <tom@...bertland.com>

I checked that you haven't missed any instances of csum_not_inet unmodified.

The rename seems straightforward and unobjectionable given that the description
of the csum_not_inet field said that it was a crc32 anway.

The previous name also contained an awkward negation. Removing that seems like
an improvement.

FWIW,

Reviewed-by: Mina Almasry <almasrymina@...gle.com>