[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240723164818.GA760263@bhelgaas>
Date: Tue, 23 Jul 2024 11:48:18 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Wei Huang <wei.huang2@....com>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, netdev@...r.kernel.org,
Jonathan.Cameron@...wei.com, corbet@....net, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
alex.williamson@...hat.com, gospo@...adcom.com,
michael.chan@...adcom.com, ajit.khaparde@...adcom.com,
somnath.kotur@...adcom.com, andrew.gospodarek@...adcom.com,
manoj.panicker2@....com, Eric.VanTassell@....com,
vadim.fedorenko@...ux.dev, horms@...nel.org, bagasdotme@...il.com,
bhelgaas@...gle.com
Subject: Re: [PATCH V3 09/10] bnxt_en: Add TPH support in BNXT driver
On Wed, Jul 17, 2024 at 03:55:10PM -0500, Wei Huang wrote:
> From: Manoj Panicker <manoj.panicker2@....com>
>
> Implement TPH support in Broadcom BNXT device driver by invoking
> pcie_tph_set_st() function when interrupt affinity is changed.
*and* invoking pcie_tph_set_st() when setting up the IRQ in the first
place, I guess?
I guess this gives a significant performance benefit? The series
includes "pci=nostmode" so the benefit can be quantified, so now I'm
curious about what you measured :)
> +static void bnxt_rtnl_lock_sp(struct bnxt *bp);
> +static void bnxt_rtnl_unlock_sp(struct bnxt *bp);
These duplicate declarations can't be right, can they? OK for
work-in-progress, but it doesn't look like the final solution.
> +static void __bnxt_irq_affinity_notify(struct irq_affinity_notify *notify,
> + const cpumask_t *mask)
> +{
> + struct bnxt_irq *irq;
> +
> + irq = container_of(notify, struct bnxt_irq, affinity_notify);
> + cpumask_copy(irq->cpu_mask, mask);
> +
> + if (!pcie_tph_set_st(irq->bp->pdev, irq->msix_nr,
> + cpumask_first(irq->cpu_mask),
> + TPH_MEM_TYPE_VM, PCI_TPH_REQ_TPH_ONLY))
> + netdev_dbg(irq->bp->dev, "error in setting steering tag\n");
> +
> + if (netif_running(irq->bp->dev)) {
> + rtnl_lock();
> + bnxt_close_nic(irq->bp, false, false);
> + bnxt_open_nic(irq->bp, false, false);
> + rtnl_unlock();
> + }
> +}
Powered by blists - more mailing lists