netdev - Re: [PATCH v1 net] l2tp: Don't assign net->gen->ptr[] for pppol2tp_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240723183425.30788-1-kuniyu@amazon.com>
Date: Tue, 23 Jul 2024 11:34:25 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <horms@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <jchapman@...alix.com>,
	<kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v1 net] l2tp: Don't assign net->gen->ptr[] for pppol2tp_net_ops.

From: Simon Horman <horms@...nel.org>
Date: Tue, 23 Jul 2024 09:50:23 +0100
> On Mon, Jul 22, 2024 at 12:15:56PM -0700, Kuniyuki Iwashima wrote:
> > Commit fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and
> > ppp parts") converted net->gen->ptr[pppol2tp_net_id] in l2tp_ppp.c to
> > net->gen->ptr[l2tp_net_id] in l2tp_core.c.
> > 
> > Now the leftover wastes one entry of net->gen->ptr[] in each netns.
> > 
> > Let's avoid the unwanted allocation.
> > 
> > Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts")
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> 
> Hi Iwashima-san,
> 
> It looks like this problem is a resource overuse that has been present
> since 2010. So I lean towards it being a clean-up for net-next rather than
> a fix.
> 
> That notwithstanding, this looks good to me.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Thanks, Simon.

Will post this next week in a seris.