netdev - Re: [PATCH net] l2tp: make session IDR and tunnel session list coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a0ebced-e19b-4dbe-9621-08b1867d313b@redhat.com>
Date: Tue, 23 Jul 2024 11:13:15 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: James Chapman <jchapman@...alix.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 tparkin@...alix.com, samuel.thibault@...-lyon.org, thorsten.blum@...lux.com
Subject: Re: [PATCH net] l2tp: make session IDR and tunnel session list
 coherent

On 7/18/24 15:43, James Chapman wrote:
> Modify l2tp_session_register and l2tp_session_unhash so that the
> session IDR and tunnel session lists remain coherent. To do so, hold
> the session IDR lock and the tunnel's session list lock when making
> any changes to either list.

Looks good for net.

AFAICS, after this patch, every time 'l2tp_session_idr_lock' is 
acquired, 'list_lock' is already held; as a possible net-next follow-up 
you could remove completely the 'l2tp_session_idr_lock' lock, and update 
accordingly the related lockdep_assert_held() assertion.

Cheers,

Paolo