[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1fa043fa-2406-452d-8078-636679428a1a@redhat.com>
Date: Tue, 23 Jul 2024 11:38:15 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Bartosz Golaszewski <brgl@...ev.pl>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>, Russell King
<linux@...linux.org.uk>, "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Jon Hunter <jonathanh@...dia.com>
Subject: Re: [RFT PATCH net] net: phy: aquantia: only poll GLOBAL_CFG
registers on aqr113c and aqr115c
On 7/18/24 16:57, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Commit 708405f3e56e ("net: phy: aquantia: wait for the GLOBAL_CFG to
> start returning real values") introduced a workaround for an issue
> observed on aqr115c. However there were never any reports of it
> happening on other models and the workaround has been reported to cause
> and issue on aqr113c (and it may cause the same on any other model not
> supporting 10M mode).
>
> Let's limit the impact of the workaround to aqr113c and aqr115c and poll
AFAICS this patch also affect aqr113, I guess the commit message should
be updated accordingly.
[...]
> @@ -708,6 +702,25 @@ static int aqr107_fill_interface_modes(struct phy_device *phydev)
> return 0;
> }
>
> +static int aqr113c_fill_interface_modes(struct phy_device *phydev)
> +{
> + int val, ret;
> +
> + /* It's been observed on some models that - when coming out of suspend
> + * - the FW signals that the PHY is ready but the GLOBAL_CFG registers
> + * continue on returning zeroes for some time. Let's poll the 10M
Please address the typo above as noted by Antoine.
Thanks!
Paolo
Powered by blists - more mailing lists