netdev - Re: [PATCH] net: stmmac: fix the mistake of the device tree property string of reset gpio in stmmac_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9517ec9-dbe1-43c6-879a-438defdc201f@redhat.com>
Date: Tue, 23 Jul 2024 12:47:57 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Zhouyi Zhou <zhouzhouyi@...il.com>, alexandre.torgue@...s.st.com,
 joabreu@...opsys.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, mcoquelin.stm32@...il.com, andrew@...n.ch,
 linus.walleij@...aro.org, martin.blumenstingl@...glemail.com,
 netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: "zhili.liu" <zhili.liu@...s.com.cn>,
 wangzhiqiang <zhiqiangwang@...s.com.cn>
Subject: Re: [PATCH] net: stmmac: fix the mistake of the device tree property
 string of reset gpio in stmmac_mdio_reset

On 7/20/24 06:00, Zhouyi Zhou wrote:
> From: "zhili.liu" <zhili.liu@...s.com.cn>
> 
> According to Documentation/devicetree/bindings/net/snps,dwmac.yaml,
> the device tree property of PHY Reset GPIO should be "snps,reset-gpio".
> 
> Use string "snps,reset-gpio" instead of "snps,reset" in stmmac_mdio_reset
> when invoking devm_gpiod_get_optional.
> 
> Fixes: 7c86f20d15b7 ("net: stmmac: use GPIO descriptors in stmmac_mdio_reset")
> 
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>
> Signed-off-by: wangzhiqiang <zhiqiangwang@...s.com.cn>
> Signed-off-by: zhili.liu <zhili.liu@...s.com.cn>

Apart from the more relevant concern raised from Andrew, please note 
that you should avoid empty lines in the tag area, between the 'fixes' 
tag and the SoB tag.

Thanks,

Paolo