netdev - RE: [Intel-wired-lan] [iwl-next v5 08/15] ice: make representor code generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5865AB5FF3A7F04093A191608FA92@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Tue, 23 Jul 2024 11:21:13 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "shayd@...dia.com" <shayd@...dia.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "horms@...nel.org" <horms@...nel.org>,
	"Samudrala, Sridhar" <sridhar.samudrala@...el.com>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "jiri@...dia.com" <jiri@...dia.com>,
	"kalesh-anakkur.purayil@...adcom.com" <kalesh-anakkur.purayil@...adcom.com>,
	"Kubiak, Michal" <michal.kubiak@...el.com>, "pio.raczynski@...il.com"
	<pio.raczynski@...il.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Drewek, Wojciech" <wojciech.drewek@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-next v5 08/15] ice: make representor code
 generic

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Michal
> Swiatkowski
> Sent: Thursday, June 6, 2024 1:25 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: shayd@...dia.com; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
> horms@...nel.org; Samudrala, Sridhar <sridhar.samudrala@...el.com>;
> Polchlopek, Mateusz <mateusz.polchlopek@...el.com>; netdev@...r.kernel.org;
> jiri@...dia.com; kalesh-anakkur.purayil@...adcom.com; Kubiak, Michal
> <michal.kubiak@...el.com>; pio.raczynski@...il.com; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
> Drewek, Wojciech <wojciech.drewek@...el.com>
> Subject: [Intel-wired-lan] [iwl-next v5 08/15] ice: make representor code generic
> 
> Keep the same flow of port representor creation, but instead of general attach
> function create helpers for specific representor type.
> 
> Store function pointer for add and remove representor.
> 
> Type of port representor can be also known based on VSI type, but it is more
> clean to have it directly saved in port representor structure.
> 
> Add devlink lock for whole port representor creation and destruction.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  .../ethernet/intel/ice/devlink/devlink_port.h |  2 +
> drivers/net/ethernet/intel/ice/ice_eswitch.c  | 74 +++++++++++-----
> drivers/net/ethernet/intel/ice/ice_eswitch.h  | 11 +--
>  drivers/net/ethernet/intel/ice/ice_repr.c     | 88 +++++++++----------
>  drivers/net/ethernet/intel/ice/ice_repr.h     | 16 +++-
>  drivers/net/ethernet/intel/ice/ice_sriov.c    |  4 +-
>  drivers/net/ethernet/intel/ice/ice_vf_lib.c   |  4 +-
>  7 files changed, 122 insertions(+), 77 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> b/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> index 97b21b58c300..479d2b976745 100644
> --- a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> @@ -14,6 +14,7 @@

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>