netdev - RE: [Intel-wired-lan] [iwl-next v5 13/15] ice: support subfunction devlink Tx topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58650556467CC6FB3A5874DC8FA92@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Tue, 23 Jul 2024 11:25:10 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "shayd@...dia.com" <shayd@...dia.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "horms@...nel.org" <horms@...nel.org>,
	"Samudrala, Sridhar" <sridhar.samudrala@...el.com>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "jiri@...dia.com" <jiri@...dia.com>,
	"kalesh-anakkur.purayil@...adcom.com" <kalesh-anakkur.purayil@...adcom.com>,
	"Kubiak, Michal" <michal.kubiak@...el.com>, "pio.raczynski@...il.com"
	<pio.raczynski@...il.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Drewek, Wojciech" <wojciech.drewek@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-next v5 13/15] ice: support subfunction
 devlink Tx topology

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Michal
> Swiatkowski
> Sent: Thursday, June 6, 2024 1:25 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: shayd@...dia.com; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
> horms@...nel.org; Samudrala, Sridhar <sridhar.samudrala@...el.com>;
> Polchlopek, Mateusz <mateusz.polchlopek@...el.com>; netdev@...r.kernel.org;
> jiri@...dia.com; kalesh-anakkur.purayil@...adcom.com; Kubiak, Michal
> <michal.kubiak@...el.com>; pio.raczynski@...il.com; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
> Drewek, Wojciech <wojciech.drewek@...el.com>
> Subject: [Intel-wired-lan] [iwl-next v5 13/15] ice: support subfunction devlink Tx
> topology
> 
> Flow for creating Tx topology is the same as for VF port representors, but the
> devlink port is stored in different place (sf->devlink_port).
> 
> When creating VF devlink lock isn't taken, when creating subfunction it is. Setting
> Tx topology function needs to take this lock, check if it was taken before to not do
> it twice.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/devlink/devlink.c     | 12 ++++++++++++
>  .../net/ethernet/intel/ice/devlink/devlink_port.c    |  1 +
>  drivers/net/ethernet/intel/ice/ice_repr.c            | 12 +++++++-----
>  3 files changed, 20 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> index 9bcbd04d29a9..037f4621e517 100644
> --- a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> @@ -746,6 +746,7 @@ static void ice_traverse_tx_tree(struct devlink *devlink,


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>