netdev - Re: [PATCH iwl-next v3 03/13] ice: add debugging functions for the parser sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3697e6a7-ae12-4634-8cc1-9dc4faf8c6fd@intel.com>
Date: Wed, 24 Jul 2024 10:19:20 -0600
From: Ahmed Zaki <ahmed.zaki@...el.com>
To: Simon Horman <horms@...nel.org>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<anthony.l.nguyen@...el.com>, Junfeng Guo <junfeng.guo@...el.com>, "Marcin
 Szycik" <marcin.szycik@...ux.intel.com>
Subject: Re: [PATCH iwl-next v3 03/13] ice: add debugging functions for the
 parser sections



On 2024-07-22 8:53 a.m., Simon Horman wrote:
> On Wed, Jul 10, 2024 at 02:40:05PM -0600, Ahmed Zaki wrote:
>> From: Junfeng Guo <junfeng.guo@...el.com>
>>
>> Add debug for all parser sections.
>>
>> Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
>> Signed-off-by: Qi Zhang <qi.z.zhang@...el.com>
>> Signed-off-by: Junfeng Guo <junfeng.guo@...el.com>
>> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
> 
> Hi Jungfeng, Ahmed, all.
> 
> I am wondering if a mechanism other than writing to the system log
> was considered for this debugging information, e.g. debugfs.
> 

I am not aware of any other mechanisms that were considered.

The series loads the parser registers on demand from other parts of the 
driver, then destroys all these states and values once the packet/hdr 
parsing is done, so I am not sure if debugfs (or any other fs-based 
method) would be useful here.