netdev - Re: [PATCH v2 net] net: usb: sr9700: fix uninitialized variable use in sr_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b944909b-1e75-4ec2-9c0e-e90269d7bf84@lunn.ch>
Date: Thu, 25 Jul 2024 01:12:20 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ma Ke <make24@...as.ac.cn>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, liujunliang_ljl@....com,
	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] net: usb: sr9700: fix uninitialized variable use
 in sr_mdio_read

On Wed, Jul 24, 2024 at 09:15:54AM +0800, Ma Ke wrote:
> It could lead to error happen because the variable res is not updated if
> the call to sr_share_read_word returns an error. In this particular case
> error code was returned and res stayed uninitialized.
> 
> This can be avoided by checking the return value of sr_share_read_word
> and propagating the error if the read operation failed.
> 
> Found by code review.

For V1, you were given the comment that there are other functions
which also suffer from this problem. You don't appear to of addressed
them in this patch, nor replied saying you won't because....

Please don't ignore reviewers.

	Andrew