[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240724135622.1797145-1-syoshida@redhat.com>
Date: Wed, 24 Jul 2024 22:56:22 +0900
From: Shigeru Yoshida <syoshida@...hat.com>
To: davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com
Cc: netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Shigeru Yoshida <syoshida@...hat.com>
Subject: [PATCH net] macvlan: Return error on register_netdevice_notifier() failure
register_netdevice_notifier() may fail, but macvlan_init_module() does
not handle the failure. Handle the failure by returning an error.
Fixes: b863ceb7ddce ("[NET]: Add macvlan driver")
Signed-off-by: Shigeru Yoshida <syoshida@...hat.com>
---
drivers/net/macvlan.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 24298a33e0e9..ae2f1a8325a5 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -1849,7 +1849,9 @@ static int __init macvlan_init_module(void)
{
int err;
- register_netdevice_notifier(&macvlan_notifier_block);
+ err = register_netdevice_notifier(&macvlan_notifier_block);
+ if (err < 0)
+ return err;
err = macvlan_link_register(&macvlan_link_ops);
if (err < 0)
--
2.45.2
Powered by blists - more mailing lists