netdev - Re: [net PATCH] fbnic: Change kconfig prompt from S390=n to !S390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqKIvuKvbsucyd2m@LQ3V64L9R2>
Date: Thu, 25 Jul 2024 10:17:50 -0700
From: Joe Damato <jdamato@...tly.com>
To: Alexander Duyck <alexander.duyck@...il.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
	pabeni@...hat.com, kernel-team@...a.com
Subject: Re: [net PATCH] fbnic: Change kconfig prompt from S390=n to !S390

On Thu, Jul 25, 2024 at 10:03:54AM -0700, Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@...com>
> 
> In testing the recent kernel I found that the fbnic driver couldn't be
> enabled on x86_64 builds. A bit of digging showed that the fbnic driver was
> the only one to check for S390 to be n, all others had checked for !S390.
> Since it is a boolean and not a tristate I am not sure it will be N. So
> just update it to use the !S390 flag.
> 
> A quick check via "make menuconfig" verified that after making this change
> there was an option to select the fbnic driver.
> 
> Signed-off-by: Alexander Duyck <alexanderduyck@...com>

[...]

This seems fine to me (and matches other drivers as you mentioned),
but does it need:

Fixes 0e03c643dc93 ("eth: fbnic: fix s390 build.") 

for it be applied to net?

In either case:

Reviewed-by: Joe Damato <jdamato@...tly.com>