netdev - Re: [PATCH net] net: ethernet: lantiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <569cd471-4fcb-49d1-b5b6-39e8ff7e72d0@wp.pl>
Date: Thu, 25 Jul 2024 21:47:08 +0200
From: Aleksander Jan Bajkowski <olek2@...pl>
To: Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, shannon.nelson@....com,
 sd@...asysnail.net, u.kleine-koenig@...gutronix.de, john@...ozen.org,
 ralf@...ux-mips.org, ralph.hempel@...tiq.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: lantiq_etop: fix memory disclosure


On 16.07.2024 21:27, Aleksander Jan Bajkowski wrote:
> Hi Paolo,
>
> On 16.07.2024 11:46, Paolo Abeni wrote:
>> On 7/14/24 00:33, Aleksander Jan Bajkowski wrote:
>>> diff --git a/drivers/net/ethernet/lantiq_etop.c 
>>> b/drivers/net/ethernet/lantiq_etop.c
>>> index 0b9982804370..196715d9ea43 100644
>>> --- a/drivers/net/ethernet/lantiq_etop.c
>>> +++ b/drivers/net/ethernet/lantiq_etop.c
>>> @@ -478,11 +478,11 @@ ltq_etop_tx(struct sk_buff *skb, struct 
>>> net_device *dev)
>>>       struct ltq_etop_priv *priv = netdev_priv(dev);
>>>       struct ltq_etop_chan *ch = &priv->ch[(queue << 1) | 1];
>>>       struct ltq_dma_desc *desc = &ch->dma.desc_base[ch->dma.desc];
>>> -    int len;
>>>       unsigned long flags;
>>>       u32 byte_offset;
>>>   -    len = skb->len < ETH_ZLEN ? ETH_ZLEN : skb->len;
>>> +    if (skb_put_padto(skb, ETH_ZLEN))
>>
>> You may want to increment tx drop stats here.
>
> Statistics are on my TODO list. The current version of this driver
> does not support statistics, so I will add them then. I would first
> prefer to fix all the bugs present in the current version of the driver
> and then add new features.


Can this patch be merged? With the current form, it should be easy
to backport. I will add statistics to this driver in the future. I think it
doesn't make sense to increment only one statistic of dropped packets.

>
>
>>
>> Thanks,
>>
>> Paolo
>>
> Best regards,
> Aleksander
>
>