netdev - Re: [RFC PATCH 01/15] l2tp: lookup tunnel from socket without using sk_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd7fd63c-3d7d-1c47-d8ae-1ff4d6f65221@katalix.com>
Date: Thu, 25 Jul 2024 08:44:18 +0100
From: James Chapman <jchapman@...alix.com>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org, tparkin@...alix.com
Subject: Re: [RFC PATCH 01/15] l2tp: lookup tunnel from socket without using
 sk_user_data

On 24/07/2024 17:33, Simon Horman wrote:
> On Tue, Jul 23, 2024 at 02:51:29PM +0100, James Chapman wrote:
>> l2tp_sk_to_tunnel derives the tunnel from sk_user_data. Instead,
>> lookup the tunnel by walking the tunnel IDR for a tunnel using the
>> indicated sock. This is slow but l2tp_sk_to_tunnel is not used in
>> the datapath so performance isn't critical.
>>
>> l2tp_tunnel_destruct needs a variant of l2tp_sk_to_tunnel which does
>> not bump the tunnel refcount since the tunnel refcount is already 0.
>>
>> Change l2tp_sk_to_tunnel sk arg to const since it does not modify sk.
> 
> nit: This needs a Signed-off-by line

I thought Signed-off-by tags weren't necessary for RFC patches. I'll add 
them when I resubmit the series when netdev reopens.

Thanks for looking at the patches.