netdev - Re: [PATCH net-next V2 3/4] net: lan743x: Migrate phylib to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqIcGbGktHjsILeu@HYD-DK-UNGSW21.microchip.com>
Date: Thu, 25 Jul 2024 15:04:17 +0530
From: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <kuba@...nel.org>, <horms@...nel.org>,
	<hkallweit1@...il.com>, <richardcochran@...il.com>, <rdunlap@...radead.org>,
	<linux@...linux.org.uk>, <bryan.whitehead@...rochip.com>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next V2 3/4] net: lan743x: Migrate phylib to phylink

Hi Andrew,

Thank you for review the patches.

The 07/18/2024 05:43, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Tue, Jul 16, 2024 at 05:03:48PM +0530, Raju Lakkaraju wrote:
> > Migrate phy support from phylib to phylink.
> > Fixed phy support is still used together with phylink since we need to support
> > dynamic fallback when a phy is not found over mdio. While phylink's FIXED mode
> > supports fixed phys that, it's dynamic and requires device tree entries which
> > are most of the time not present for LAN743x devices
> 
> > +static int lan743x_phylink_connect(struct lan743x_adapter *adapter)
> > +{
> > +     struct device_node *dn = adapter->pdev->dev.of_node;
> > +     struct net_device *dev = adapter->netdev;
> > +     struct fixed_phy_status fphy_status = {
> > +             .link = 1,
> > +             .speed = SPEED_1000,
> > +             .duplex = DUPLEX_FULL,
> > +     };
> 
> 
> So you are happy to limit it to 1G, even thought it can do more? That
> is the problem with fixed PHY done this way. If you were to use
> PHYLINK fixed PHY you can use the full bandwidth of the hardware.
> 

I accept your comments. Fixed PHY hard coded to 1Gpbs.

Currenly, LAN743x chip don't have Device Tree implemented. 
As part of SFP support, I would like to add software nodes.
After SFP support development, I will add "fixed-link" option in software nodes.

> You might want to look at what the wangxun drivers do for some ideas
> how you can make use of PHYLINK fixed link without having DT.

I refer the wangxun drivers for "fixed-link". currently wangxun driver did not
implement "fixed-link" in software node.
 
> 
>     Andrew
> 

-- 
Thanks,                                                                         
Raju