netdev - Re: [PATCH RFC v2 01/11] netlink: spec: add shaper YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5c5f6bb-58ae-4d59-8edb-66fc587e3ff8@redhat.com>
Date: Thu, 25 Jul 2024 13:42:18 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: netdev@...r.kernel.org
Cc: Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>,
 Madhu Chittim <madhu.chittim@...el.com>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Simon Horman <horms@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>,
 Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH RFC v2 01/11] netlink: spec: add shaper YAML spec

On 7/24/24 22:24, Paolo Abeni wrote:
> Define the user-space visible interface to query, configure and delete
> network shapers via yaml definition.
> 
> Add dummy implementations for the relevant NL callbacks.
> 
> set() and delete() operations touch a single shaper creating/updating or
> deleting it.
> The group() operation creates a shaper's group, nesting multiple input
> shapers under the specified output shaper.
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> RFC v1 -> RFC v2:
>   - u64 -> uint
>   - net_shapers -> net-shapers
>   - documented all the attributes
>   - dropped [ admin-perm ] for get() op
>   - group op
>   - set/delete touch a single shaper

FWIW, the CI told me I forgot entirely about the generated user-space 
code, and the naming here is not supported by the current tooling. I'll 
send something alike the following when net-next re-open.
---
diff --git a/tools/net/ynl/ynl-gen-c.py b/tools/net/ynl/ynl-gen-c.py
index 51529fabd517..717530bc9c52 100755
--- a/tools/net/ynl/ynl-gen-c.py
+++ b/tools/net/ynl/ynl-gen-c.py
@@ -2668,13 +2668,15 @@ def main():
          cw.p('#define ' + hdr_prot)
          cw.nl()

+    hdr_file=os.path.basename(args.out_file[:-2]) + ".h"
+
      if args.mode == 'kernel':
          cw.p('#include <net/netlink.h>')
          cw.p('#include <net/genetlink.h>')
          cw.nl()
          if not args.header:
              if args.out_file:
-                cw.p(f'#include 
"{os.path.basename(args.out_file[:-2])}.h"')
+                cw.p(f'#include "{hdr_file}"')
              cw.nl()
          headers = ['uapi/' + parsed.uapi_header]
          headers += parsed.kernel_family.get('headers', [])
@@ -2686,7 +2688,7 @@ def main():
              if family_contains_bitfield32(parsed):
                  cw.p('#include <linux/netlink.h>')
          else:
-            cw.p(f'#include "{parsed.name}-user.h"')
+            cw.p(f'#include "{hdr_file}"')
              cw.p('#include "ynl.h"')
          headers = [parsed.uapi_header]
      for definition in parsed['definitions']: