netdev - Re: [PATCH net 4/5] ethtool: fix the state of additional contexts with old API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e705f0d0-557f-1ad9-e704-f6a0d899c70b@gmail.com>
Date: Fri, 26 Jul 2024 06:06:04 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 michael.chan@...adcom.com, shuah@...nel.org, przemyslaw.kitszel@...el.com,
 ahmed.zaki@...el.com, andrew@...n.ch, willemb@...gle.com,
 pavan.chebbi@...adcom.com, petrm@...dia.com
Subject: Re: [PATCH net 4/5] ethtool: fix the state of additional contexts
 with old API

On 25/07/2024 23:23, Jakub Kicinski wrote:
> We expect drivers implementing the new create/modify/destroy
> API to populate the defaults in struct ethtool_rxfh_context.
> In legacy API ctx isn't even passed, and rxfh.indir / rxfh.key
> are NULL so drivers can't give us defaults even if they want to.
> Call get_rxfh() to fetch the values. We can reuse rxfh_dev
> for the get_rxfh(), rxfh stores the input from the user.
> 
> This fixes IOCTL reporting 0s instead of the default key /
> indir table for drivers using legacy API.
> 
> Add a check to try to catch drivers using the new API
> but not populating the key.
> 
> Fixes: 7964e7884643 ("net: ethtool: use the tracking array for get_rxfh on custom RSS contexts")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Edward Cree <ecree.xilinx@...il.com>