netdev - Re: [PATCH v4 iwl-next 0/4] ice: Implement PTP support for E830 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240726172823.GA1699125@kernel.org>
Date: Fri, 26 Jul 2024 18:28:23 +0100
From: Simon Horman <horms@...nel.org>
To: Karol Kolacinski <karol.kolacinski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com
Subject: Re: [PATCH v4 iwl-next 0/4] ice: Implement PTP support for E830
 devices

On Fri, Jul 26, 2024 at 01:34:42PM +0200, Karol Kolacinski wrote:
> Add specific functions and definitions for E830 devices to enable
> PTP support.
> Refactor processing of timestamping interrupt and cross timestamp
> to avoid code redundancy.
> 
> Jacob Keller (1):
>   ice: combine cross timestamp functions for E82x and E830
> 
> Karol Kolacinski (2):
>   ice: Process TSYN IRQ in a separate function
>   ice: Add timestamp ready bitmap for E830 products
> 
> Michal Michalik (1):
>   ice: Implement PTP support for E830 devices
> 
>  drivers/net/ethernet/intel/Kconfig            |  10 +-
>  drivers/net/ethernet/intel/ice/ice_common.c   |  17 +-
>  drivers/net/ethernet/intel/ice/ice_common.h   |   1 +
>  .../net/ethernet/intel/ice/ice_hw_autogen.h   |  12 +
>  drivers/net/ethernet/intel/ice/ice_main.c     |  25 +-
>  drivers/net/ethernet/intel/ice/ice_osdep.h    |   3 +
>  drivers/net/ethernet/intel/ice/ice_ptp.c      | 356 ++++++++++++------
>  drivers/net/ethernet/intel/ice/ice_ptp.h      |   9 +-
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 208 +++++++++-
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |  25 +-
>  drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
>  11 files changed, 508 insertions(+), 159 deletions(-)
> 
> V3 -> V4: Further kdoc fixes in "ice: Implement PTP support for
>           E830 devices"
> V2 -> V3: Rebased and fixed kdoc in "ice: Implement PTP support for
>           E830 devices"
> V1 -> V2: Fixed compilation issue in "ice: Implement PTP support for
>           E830 devices"

As the recent changes are about kdoc, please consider running
kernel-doc -none -Wall and ensuring no new warnings are introduced:
ice_is_e830 needs a short description.

And, perhaps things crossed in flight.
But please address the review by Jacob and Alexander of v3.

Thanks!