netdev - Re: [PATCH] bnxt_en: Fix RSS logic in __bnxt_reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALs4sv23LxGYT=CrwTgMd9d1=jvCH5eqsJtnWgBS2VvOVdz0Bg@mail.gmail.com>
Date: Fri, 26 Jul 2024 11:53:08 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andy Gospodarek <andrew.gospodarek@...adcom.com>, 
	Michael Chan <michael.chan@...adcom.com>, davem@...emloft.net, netdev@...r.kernel.org, 
	edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH] bnxt_en: Fix RSS logic in __bnxt_reserve_rings()

On Fri, Jul 26, 2024 at 4:02 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 25 Jul 2024 17:33:10 -0400 Andy Gospodarek wrote:
> > > The Check failure tells us the traffic was sprayed.
> > > The Defer Exception, well, self-explanatory:
> > >   "Cannot delete RX class rule: No such file or directory"
> >
> > We can take a look at that, but we currently do this on purpose.
>
> Hm, I thought the rules may get lost if someone ifconfig down's
> the entire device. Losing rules on a config change is much more
> of a no-no, especially as long as the queue API remains all but
> a mirage.

The rules won't be lost on ifconfig down. They will be lost in
firmware but driver will restore them on ifup.
I will work on the fix to not lose them on any non-impacting config
change. Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)