netdev - Re: [PATCH] net: axienet: start napi before enabling Rx/Tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKNACSRA05bUM7xVc2vXAjh0jk6P7+b3TFM99mMW9CmFw@mail.gmail.com>
Date: Fri, 26 Jul 2024 09:41:47 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Andy Chiu <andy.chiu@...ive.com>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Michal Simek <michal.simek@....com>, 
	Robert Hancock <robert.hancock@...ian.com>, netdev@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: axienet: start napi before enabling Rx/Tx

On Fri, Jul 26, 2024 at 9:06 AM Andy Chiu <andy.chiu@...ive.com> wrote:
>
> softirq may get lost if an Rx interrupt comes before we call
> napi_enable. Move napi_enable in front of axienet_setoptions(), which
> turns on the device, to address the issue.
>
> Link: https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg06160.html
> Fixes: cc37610caaf8 ("net: axienet: implement NAPI and GRO receive")
> Signed-off-by: Andy Chiu <andy.chiu@...ive.com>

SGTM, although the axienet_setoptions name is a bit confusing...

Reviewed-by: Eric Dumazet <edumazet@...gle.com>