netdev - Re: [PATCH net-next] Add support for PIO p flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240726102318.GN97837@kernel.org>
Date: Fri, 26 Jul 2024 11:23:18 +0100
From: Simon Horman <horms@...nel.org>
To: Patrick Rohr <prohr@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Linux Network Development Mailing List <netdev@...r.kernel.org>,
	Maciej Żenczykowski <maze@...gle.com>,
	Lorenzo Colitti <lorenzo@...gle.com>,
	David Lamparter <equinox@...nsourcerouting.org>
Subject: Re: [PATCH net-next] Add support for PIO p flag

On Thu, Jul 25, 2024 at 06:06:29PM -0700, Patrick Rohr wrote:
> draft-ietf-6man-pio-pflag is adding a new flag to the Prefix Information
> Option to signal the pd-per-device addressing mechanism.
> 
> When accept_pio_pflag is enabled, the presence of the p-flag will cause
> an a flag in the same PIO to be ignored.
> 
> An automated test has been added in Android (r.android.com/3195335) to
> go along with this change.
> 
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Lorenzo Colitti <lorenzo@...gle.com>
> Cc: David Lamparter <equinox@...nsourcerouting.org>
> Signed-off-by: Patrick Rohr <prohr@...gle.com>

Hi Patrick,

This is not a full review, and as per the form letter below,
net-next is closed, so you'd be best to repost.
But I will offer some very minor review in the meantime.

Firstly, please seed the CC list for Networking patches
using get_maintainers.pl --git-min-percent 25 this.patch

Secondly, as noted inline, there are two cases of
mixed of tabs and spaces used for indenting in this patch.

## Form letter - net-next-closed

The merge window for v6.11 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after 15th July

RFC patches sent for review only are welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer

...

> diff --git a/include/net/addrconf.h b/include/net/addrconf.h
> index 62a407db1bf5..59496aa23012 100644
> --- a/include/net/addrconf.h
> +++ b/include/net/addrconf.h
> @@ -38,9 +38,13 @@ struct prefix_info {
>  #if defined(__BIG_ENDIAN_BITFIELD)
>  			__u8	onlink : 1,
>  			 	autoconf : 1,
> -				reserved : 6;
> +			 	routeraddr : 1,

The line above puts a space before a tab in indentation.
This is already the case on the autoconf line, but let's not add another
instance.

Flagged by checkpatch.

> +				pdpreferred : 1,
> +				reserved : 4;
>  #elif defined(__LITTLE_ENDIAN_BITFIELD)
> -			__u8	reserved : 6,
> +			__u8	reserved : 4,
> +				pdpreferred : 1,
> +			 	routeraddr : 1,

Here too.

>  				autoconf : 1,
>  				onlink : 1;
>  #else

...