netdev - [PATCH net] tun: Add missing bpf_net_ctx_clear() in do_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240727021659.4659-1-aha310510@gmail.com>
Date: Sat, 27 Jul 2024 11:16:59 +0900
From: Jeongjun Park <aha310510@...il.com>
To: kuba@...nel.org
Cc: aha310510@...il.com,
	ast@...nel.org,
	bigeasy@...utronix.de,
	bpf@...r.kernel.org,
	daniel@...earbox.net,
	davem@...emloft.net,
	edumazet@...gle.com,
	hawk@...nel.org,
	jasowang@...hat.com,
	john.fastabend@...il.com,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	syzbot+44623300f057a28baf1e@...kaller.appspotmail.com,
	syzkaller-bugs@...glegroups.com,
	willemdebruijn.kernel@...il.com
Subject: [PATCH net] tun: Add missing bpf_net_ctx_clear() in do_xdp_generic()

Jakub Kicinski wrote:
>
> On Fri, 26 Jul 2024 06:40:49 +0900 Jeongjun Park wrote:
> > There are cases where do_xdp_generic returns bpf_net_context without
> > clearing it. This causes various memory corruptions, so the missing
> > bpf_net_ctx_clear must be added.
> >
> > Reported-by: syzbot+44623300f057a28baf1e@...kaller.appspotmail.com
> > Fixes: fecef4cd42c6 ("tun: Assign missing bpf_net_context.")
> > Signed-off-by: Jeongjun Park <aha310510@...il.com>
>
> Also likely:
>
> Reported-by: syzbot+3c2b6d5d4bec3b904933@...kaller.appspotmail.com
> Reported-by: syzbot+707d98c8649695eaf329@...kaller.appspotmail.com
>
> Right?

Yes, both appear to be bugs with the same root cause.

Regards,
Jeongjun Park