netdev - Re: [PATCH v5.15] wifi: mac80211: check basic rates validity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024072903-chihuahua-contrite-c1a6@gregkh>
Date: Mon, 29 Jul 2024 12:50:38 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Vincenzo Mezzela <vincenzo.mezzela@...il.com>
Cc: johannes@...solutions.net, sashal@...nel.org,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	javier.carrasco.cruz@...il.com, skhan@...uxfoundation.org,
	stable@...r.kernel.org, Johannes Berg <johannes.berg@...el.com>,
	syzbot+19013115c9786bfd0c4e@...kaller.appspotmail.com
Subject: Re: [PATCH v5.15] wifi: mac80211: check basic rates validity

On Sat, Jul 27, 2024 at 02:50:33PM +0200, Vincenzo Mezzela wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> commit ce04abc3fcc62cd5640af981ebfd7c4dc3bded28 upstream.
> 
> When userspace sets basic rates, it might send us some rates
> list that's empty or consists of invalid values only. We're
> currently ignoring invalid values and then may end up with a
> rates bitmap that's empty, which later results in a warning.
> 
> Reject the call if there were no valid rates.
> 
> [ Conflict resolution involved adjusting the patch to accommodate
> changes in the function signature of ieee80211_parse_bitrates,
> specifically the updated first parameter ]
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> Reported-by: syzbot+19013115c9786bfd0c4e@...kaller.appspotmail.com
> Tested-by: syzbot+19013115c9786bfd0c4e@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=19013115c9786bfd0c4e
> Signed-off-by: Vincenzo Mezzela <vincenzo.mezzela@...il.com>
> ---
>  net/mac80211/cfg.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 

We can't take a patch for 5.15 without it also being in 6.1.y for
obvious reasons.  Please provide a working version for that branch
first, and then resend this backport and we will be glad to queue it up.

thanks,

greg k-h