netdev - Re: [PATCH net-next v17 13/14] net: ethtool: Add support for tsconfig command to get/set hwtstamp config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e97152d-c992-4056-a204-861035e35d60@intel.com>
Date: Mon, 29 Jul 2024 11:02:41 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Kory Maincent <kory.maincent@...tlin.com>
CC: Florian Fainelli <florian.fainelli@...adcom.com>, "Broadcom internal
 kernel review list" <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn
	<andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
	<linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, Radu Pirea
	<radu-nicolae.pirea@....nxp.com>, Jay Vosburgh <j.vosburgh@...il.com>, "Andy
 Gospodarek" <andy@...yhouse.net>, Nicolas Ferre
	<nicolas.ferre@...rochip.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jonathan Corbet
	<corbet@....net>, "Horatiu Vultur" <horatiu.vultur@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, "Simon Horman" <horms@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, <donald.hunter@...il.com>,
	<danieller@...dia.com>, <ecree.xilinx@...il.com>, Thomas Petazzoni
	<thomas.petazzoni@...tlin.com>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-doc@...r.kernel.org>, Maxime Chevallier
	<maxime.chevallier@...tlin.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Willem de Bruijn <willemb@...gle.com>, Shannon Nelson
	<shannon.nelson@....com>, Alexandra Winter <wintera@...ux.ibm.com>
Subject: Re: [PATCH net-next v17 13/14] net: ethtool: Add support for tsconfig
 command to get/set hwtstamp config



On 7/27/2024 6:00 AM, Kory Maincent wrote:
> On Wed, 17 Jul 2024 10:43:05 -0700
> Jacob Keller <jacob.e.keller@...el.com> wrote:
>>>  A driver which supports hardware time stamping must support the
>>> -SIOCSHWTSTAMP ioctl and update the supplied struct hwtstamp_config with
>>> -the actual values as described in the section on SIOCSHWTSTAMP.  It
>>> -should also support SIOCGHWTSTAMP.
>>> +ndo_hwtstamp_set NDO or the legacy SIOCSHWTSTAMP ioctl and update the
>>> +supplied struct hwtstamp_config with the actual values as described in
>>> +the section on SIOCSHWTSTAMP. It should also support ndo_hwtstamp_get or
>>> +the legacy SIOCGHWTSTAMP.  
>>
>> Can we simply drop the mention of implementing the legacy implementation
>> on the kernel side? I guess not all existing drivers have converted yet...?
> 
> Yes indeed.>
> In fact, Vlad has already worked on converting all the existing drivers:
> https://github.com/vladimiroltean/linux/tree/ndo-hwtstamp-v9
> I can't find any patch series sent to net next. Vlad what is the status on this?
> 

Great!

>> I have a similar thought about the other legacy PTP hooks.. it is good
>> to completely remove the legacy/deprecated implementations as it means
>> drivers can't be published which don't update to new APIs. That
>> ultimately just wastes reviewer/maintainer time to point out that it
>> must be updated to new APIs.
> 
> Yes but on the userspace side linuxPTP is still using the IOCTLs uAPI that will
> become legacy with this series. Maybe it is still a bit early to remove totally
> their descriptions in the doc?
> 

Right, they would need to use the netlink implementation to get the new
features, but the ioctls can at least be translated to the new kAPI
thats in the drivers?

Removing the old APIs from the uAPI doc is bad, but I think we can
clarify the wording of the doc and update to make it clear where the
separation is.

I may take a pass at the doc to see if I think I can improve it.

> Regards,