netdev - Re: [PATCH v7 2/3] vdpa_sim_net: Add the support of set mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5898ab7-a2ad-412a-85e6-9c7ad590704c@lunn.ch>
Date: Mon, 29 Jul 2024 21:15:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Cindy Lu <lulu@...hat.com>
Cc: dtatulea@...dia.com, mst@...hat.com, jasowang@...hat.com,
	parav@...dia.com, sgarzare@...hat.com, netdev@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/3] vdpa_sim_net: Add the support of set mac address

> +static int vdpasim_net_set_attr(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev,
> +				const struct vdpa_dev_set_config *config)
> +{
> +	struct vdpasim *vdpasim = container_of(dev, struct vdpasim, vdpa);
> +	struct virtio_net_config *vio_config = vdpasim->config;
> +
> +	mutex_lock(&vdpasim->mutex);
> +
> +	if (config->mask & (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR)) {
> +		ether_addr_copy(vio_config->mac, config->net.mac);
> +		mutex_unlock(&vdpasim->mutex);
> +		return 0;
> +	}
> +
> +	mutex_unlock(&vdpasim->mutex);
> +	return -EINVAL;

EOPNOTSUPP would be more appropriate.

	Andrew