netdev - Re: [PATCH v4 5/5] wifi: brcmfmac: add flag for random seed during firmware download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYZPR03MB7001E3C50010694E5F12756080B72@TYZPR03MB7001.apcprd03.prod.outlook.com>
Date: Mon, 29 Jul 2024 08:19:50 +0000
From: Jacobe Zang <jacobe.zang@...ion.com>
To: Arend van Spriel <arend.vanspriel@...adcom.com>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"heiko@...ech.de" <heiko@...ech.de>, "kvalo@...nel.org" <kvalo@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>
CC: "efectn@...tonmail.com" <efectn@...tonmail.com>, "dsimic@...jaro.org"
	<dsimic@...jaro.org>, "jagan@...eble.ai" <jagan@...eble.ai>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-rockchip@...ts.infradead.org"
	<linux-rockchip@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "arend@...adcom.com" <arend@...adcom.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "megi@....cz"
	<megi@....cz>, "duoming@....edu.cn" <duoming@....edu.cn>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "minipli@...ecurity.net"
	<minipli@...ecurity.net>, "brcm80211@...ts.linux.dev"
	<brcm80211@...ts.linux.dev>, "brcm80211-dev-list.pdl@...adcom.com"
	<brcm80211-dev-list.pdl@...adcom.com>, Nick Xie <nick@...das.com>
Subject: Re: [PATCH v4 5/5] wifi: brcmfmac: add flag for random seed during
 firmware download

>> Providing the random seed to firmware was tied to the fact that the
>> device has a valid OTP, which worked for some Apple chips. However,
>> it turns out the BCM43752 device also needs the random seed in order
>> to get firmware running. Suspect it is simply tied to the firmware
>> branch used for the device. Introducing a mechanism to allow setting
>> it for a device through the device table.
>
> Not exactly what I meant by using my patch "as is". I would have kept
> the two patches separate, but it is not a deal breaker for me.

Oh..so the correct approach should be for me to split this commit separately?

---
Best Regards
Jacobe