netdev - Re: [PATCH AUTOSEL 6.10 03/27] r8169: remove detection of chip version 11 (early RTL8168b)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <111ac84e-0d22-43cb-953e-fc5f029fe37c@gmail.com>
Date: Mon, 29 Jul 2024 10:45:15 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Cc: Jakub Kicinski <kuba@...nel.org>, nic_swsd@...ltek.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.10 03/27] r8169: remove detection of chip
 version 11 (early RTL8168b)

On 28.07.2024 02:52, Sasha Levin wrote:
> From: Heiner Kallweit <hkallweit1@...il.com>
> 
> [ Upstream commit 982300c115d229565d7af8e8b38aa1ee7bb1f5bd ]
> 
> This early RTL8168b version was the first PCIe chip version, and it's
> quite quirky. Last sign of life is from more than 15 yrs ago.
> Let's remove detection of this chip version, we'll see whether anybody
> complains. If not, support for this chip version can be removed a few
> kernel versions later.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> Link: https://lore.kernel.org/r/875cdcf4-843c-420a-ad5d-417447b68572@gmail.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/net/ethernet/realtek/r8169_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 7b9e04884575e..d2d46fe17631a 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -2274,7 +2274,9 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
>  
>  		/* 8168B family. */
>  		{ 0x7c8, 0x380,	RTL_GIGA_MAC_VER_17 },
> -		{ 0x7c8, 0x300,	RTL_GIGA_MAC_VER_11 },
> +		/* This one is very old and rare, let's see if anybody complains.
> +		 * { 0x7c8, 0x300,	RTL_GIGA_MAC_VER_11 },
> +		 */
>  
>  		/* 8101 family. */
>  		{ 0x7c8, 0x448,	RTL_GIGA_MAC_VER_39 },

It may be the case that there are still few users out there with this ancient hw.
We will know better once 6.11 is out for a few month. In this case we would have to
revert this change. 
I don't think it's a change which should go to stable.