lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5d3c74da-7d44-4b88-8961-60f21f84f0ac@web.de>
Date: Tue, 30 Jul 2024 10:37:56 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Daniel Vetter <daniel.vetter@...ll.ch>,
 Kaiyuan Zhang <kaiyuanz@...gle.com>, Mina Almasry <almasrymina@...gle.com>,
 Pavel Begunkov <asml.silence@...il.com>,
 Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-alpha@...r.kernel.org,
 linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
 sparclinux@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-arch@...r.kernel.org, linux-kselftest@...r.kernel.org,
 bpf@...r.kernel.org, linux-media@...r.kernel.org,
 dri-devel@...ts.freedesktop.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andreas Larsson
 <andreas@...sler.com>, Arnd Bergmann <arnd@...db.de>,
 Bagas Sanjaya <bagasdotme@...il.com>,
 Christian König <christian.koenig@....com>,
 Christoph Hellwig <hch@...radead.org>, David Ahern <dsahern@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, David Wei <dw@...idwei.uk>,
 Donald Hunter <donald.hunter@...il.com>, Eric Dumazet <edumazet@...gle.com>,
 Harshitha Ramamurthy <hramamurthy@...gle.com>, Helge Deller <deller@....de>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>,
 Ivan Kokshaysky <ink@...assic.park.msu.ru>, Jakub Kicinski
 <kuba@...nel.org>,
 "James E. J. Bottomley" <James.Bottomley@...senPartnership.com>,
 Jason Gunthorpe <jgg@...pe.ca>, Jeroen de Borst <jeroendb@...gle.com>,
 Jesper Dangaard Brouer <hawk@...nel.org>, Jonathan Corbet <corbet@....net>,
 Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Matt Turner <mattst88@...il.com>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Praveen Kaligineedi <pkaligineedi@...gle.com>,
 Richard Henderson <richard.henderson@...aro.org>,
 Shailend Chand <shailend@...gle.com>, Shakeel Butt <shakeel.butt@...ux.dev>,
 Shuah Khan <shuah@...nel.org>,
 Steffen Klassert <steffen.klassert@...unet.com>,
 Steven Rostedt <rostedt@...dmis.org>, Sumit Semwal
 <sumit.semwal@...aro.org>, Taehee Yoo <ap420073@...il.com>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Yunsheng Lin <linyunsheng@...wei.com>
Subject: Re: [PATCH net-next v17 03/14] netdev: support binding dma-buf to
 netdevice

…
> +++ b/include/net/devmem.h
> @@ -0,0 +1,115 @@
…
> +#ifndef _NET_DEVMEM_H
> +#define _NET_DEVMEM_H
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ