[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240730102849.GY97837@kernel.org>
Date: Tue, 30 Jul 2024 11:28:49 +0100
From: Simon Horman <horms@...nel.org>
To: Ahmed Zaki <ahmed.zaki@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
hkelam@...vell.com, Sridhar Samudrala <sridhar.samudrala@...el.com>,
Marcin Szycik <marcin.szycik@...ux.intel.com>,
Rafal Romanowski <rafal.romanowski@...el.com>
Subject: Re: [PATCH iwl-next v5 12/13] iavf: refactor add/del FDIR filters
On Thu, Jul 25, 2024 at 04:08:08PM -0600, Ahmed Zaki wrote:
> In preparation for a second type of FDIR filters that can be added by
> tc-u32, move the add/del of the FDIR logic to be entirely contained in
> iavf_fdir.c.
>
> The iavf_find_fdir_fltr_by_loc() is renamed to iavf_find_fdir_fltr()
> to be more agnostic to the filter ID parameter (for now @loc, which is
> relevant only to current FDIR filters added via ethtool).
>
> The FDIR filter deletion is moved from iavf_del_fdir_ethtool() in
> ethtool.c to iavf_fdir_del_fltr(). While at it, fix a minor bug where
> the "fltr" is accessed out of the fdir_fltr_lock spinlock protection.
>
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists